[PATCH 2/2] mfd/ab8500: Use kstrtoul_from_user
Alexey Dobriyan
adobriyan at gmail.com
Mon Jun 20 09:45:46 EDT 2011
NAK
You should use kstrtou8_from_user() and drop 0xff check as well.
Do NOT blindly replace strict_strtoul with kstrtoul.
On Mon, Jun 6, 2011 at 11:43 PM, Peter Huewe <peterhuewe at gmx.de> wrote:
> - err = strict_strtoul(buf, 0, &user_val);
> + err = kstrtoul_from_user(user_buf, count, 0, &user_val);
> if (err)
> - return -EINVAL;
> + return err;
> +
> if (user_val > 0xff) {
> dev_err(dev, "debugfs error input > 0xff\n");
> return -EINVAL;
More information about the linux-arm-kernel
mailing list