[PATCH] collie: don't read GPSR

Eric Miao eric.y.miao at gmail.com
Fri Jun 17 11:07:59 EDT 2011


Would it be better to switch to use gpio_* API instead of manipulating
GPxR directly?

On Fri, Jun 17, 2011 at 10:11 PM, Dmitry Eremin-Solenikov
<dbaryshkov at gmail.com> wrote:
> On StrongARM GPSR is write-only according to docs, so don't read from
> it. Just set the required GPIO.
>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov at gmail.com>
> ---
>  arch/arm/mach-sa1100/collie.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-sa1100/collie.c b/arch/arm/mach-sa1100/collie.c
> index f28025e..3f32ba2 100644
> --- a/arch/arm/mach-sa1100/collie.c
> +++ b/arch/arm/mach-sa1100/collie.c
> @@ -339,7 +339,7 @@ static void __init collie_init(void)
>
>        PCFR = PCFR_OPDE;
>
> -       GPSR |= _COLLIE_GPIO_UCB1x00_RESET;
> +       GPSR = _COLLIE_GPIO_UCB1x00_RESET;
>
>
>        platform_scoop_config = &collie_pcmcia_config;
> --
> 1.7.5.3
>
>



More information about the linux-arm-kernel mailing list