[PATCH] mach-ixp4xx: fix build error

Linus Walleij linus.walleij at linaro.org
Wed Jun 15 10:57:54 EDT 2011

On Wed, Jun 15, 2011 at 3:29 PM, Richard Cochran
<richardcochran at gmail.com> wrote:
> On Wed, Jun 15, 2011 at 10:43:10AM +0200, Linus Walleij wrote:
>> From: Linus Walleij <linus.walleij at linaro.org>
>> The introduction of clocksource_mmio_init() broke ixp4xx due to
>> a surplus ampersand - IXP4XX_OSTS is already a pointe to I/O
>> space.
> The fix you suggest will not work on big endian ixp. See

Yeah! I see. Sorry for missing it, I was just looking over the broken
kisskb items.

>   http://lists.arm.linux.org.uk/lurker/message/20110530.084307.f960f906.en.html

You do this:

+static cycle_t ixp4xx_clocksource_read(struct clocksource *c)
+    return *IXP4XX_OSTS;

Which is essentially __raw_readl(IXP4XX_OSTS) to get the timer in current
endianness, is it not? So please use __raw_readl() for that if I'm right.

Linus Walleij

More information about the linux-arm-kernel mailing list