[PATCH v2] arm: omap3: cm-t35: add support for cm-t3730

Tony Lindgren tony at atomide.com
Mon Jun 13 09:33:07 EDT 2011

* Igor Grinberg <grinberg at compulab.co.il> [110603 06:33]:
> I'm not sure I understand what are you trying to propose here...
> If you look once again on the code, there is currently only one if (cpu_is_..) {} else {}
> statement currently present.
> (I can remove the "if (cpu_is_omap3630())" - it indeed has no value)
> Indeed, there will be some other differences...
> Each time I submit a patch, I try to be as optimal as I can,
> but again I'm open for suggestions...
> (though I think it is optimal, e.g. 33 lines for a new running board...)

What I meant is that maybe you should do the detection first in some
get_revision function and populate the gpio pins there. Sort of like
this recent beagle patch:


That way adding support for other differences will be easier.



More information about the linux-arm-kernel mailing list