[PATCH] arm, exec: remove redundant set_fs(USER_DS)

Mathias Krause minipli at googlemail.com
Fri Jun 10 09:53:24 EDT 2011

On Fri, Jun 10, 2011 at 3:48 PM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Fri, Jun 10, 2011 at 03:08:57PM +0200, Mathias Krause wrote:
>> The address limit is already set in flush_old_exec() so this
>> set_fs(USER_DS) is redundant.
> Please show where and how this is done.  I've looked and can't see
> any equivalent call to set_fs() in flush_old_exec().

Before dac853a (exec: delay address limit change until point of no
return) it was done in search_binary_handler(), now it is done in
flush_old_exec(). Either way set_fs(USER_DS) was/gets called before
start_thread() so the call there is redundant.


More information about the linux-arm-kernel mailing list