[PATCH 2/3] ts72xx: use MTDPART_OFS_RETAIN for mtd partitioning
ynezz at true.cz
Sat Jun 11 05:22:24 EDT 2011
Dmitry Eremin-Solenikov <dbaryshkov at gmail.com> [2011-06-06 18:04:15]:
> Instead of specifying a callback for dynamic partitioning, use
> MTDPART_OFS_RETAIN for reserving a place near the end of flash for
> - .offset = MTDPART_OFS_APPEND,
> - .size = 0, /* filled in later */
> + .offset = MTDPART_OFS_RETAIN,
> + .size = TS72XX_REDBOOT_PART_SIZE,
> + /* leave so much for last partition */
thank you for the mtd cleanup work. While testing this patch, I've noticed,
that the TS72XX_REDBOOT_PART_SIZE is by 16K bigger, then it should be:
RedBoot> fis list
Name FLASH addr Mem addr Length Entry point
(reserved) 0x60000000 0x60000000 0x01D04000 0x00000000
RedBoot 0x61D04000 0x61D04000 0x00040000 0x00000000
vmlinux 0x61D44000 0x00218000 0x000C0000 0x00218000
FIS directory 0x61FFC000 0x61FFC000 0x00003000 0x00000000
RedBoot config 0x61FFF000 0x61FFF000 0x00001000 0x00000000
0x000000000000-0x000000004000 : "TS-BOOTROM"
0x000000004000-0x000001d00000 : "Linux"
0x000001d00000-0x000002000000 : "RedBoot"
So if I simply read now first 4 bytes from /dev/mtdblock2, there's no 'CRUS'
or 'SURC' boot HeaderID/signature and it means, that there's no valid Redboot
for ep93xx. The correct value is:
#define TS72XX_REDBOOT_PART_SIZE (SZ_2M + SZ_1M - SZ_16K)
And in the current state one could easily overwrite fis/fconfig while
upgrading the Redboot from the Linux userspace and brick the board, because
there's fis/fconfig stuff included in that Redboot partition.
I think, that it would be better to either make that Redboot partition
read-only by default, make it smaller so it wouldn't contain fconfig/fis parts
in it or add fis/fconfig partitions also. I don't know what's preffered way of
handling this, but since we're touching that part of the code, we should fix
Adding Mika to the Cc loop, since he has ts-7260.
More information about the linux-arm-kernel