[PATCH] gpio-ep93xx: convert to platform_driver and use basic_mmio_gpio library

H Hartley Sweeten hartleys at visionengravers.com
Thu Jun 9 14:44:54 EDT 2011


On Thursday, June 09, 2011 11:42 AM, Grant Likely wrote:
> On Thu, Jun 9, 2011 at 10:43 AM, H Hartley Sweeten wrote:
>> On Wednesday, June 08, 2011 3:08 PM, Grant Likely wrote:
>>>
>>> Merged, thanks.
>>
>> Thanks.  I just noticed I left in a debug message I added when changing
>> this to a platform_driver.
>>
>>>> +static int __init ep93xx_gpio_init(void)
>>>> +{
>>>> +    pr_info("%s\n", __func__);
>>>> +    return platform_driver_register(&ep93xx_gpio_driver);
>>>>  }
>>
>> That pr_info shouldn't be there.  It just adds noise.
>>
>> Would you prefer a full new patch or just an incremental patch to remove
>> this line?  The patch is already in next-20110609.
>>
>> Thanks, sorry for the trouble
>
> Neither.  I just fixed it up and pushed out a commit.

Thanks!

Regards,
Hartley


More information about the linux-arm-kernel mailing list