[PATCH v3 2/4] mmc: support sdhci-pxav2.c

[zhangfei gao]

On Tue, Jun 7, 2011 at 11:04 PM, Philip Rakity <prakity at marvell.com> wrote:
>
> On Jun 7, 2011, at 12:31 AM, Eric Miao wrote:
>
>>> How about changing the title of the option though? A user will
>>> usually not know if he is using the v2 or v3 controller without
>>> reading the help text. If you change it to
>>>
>>> config MMC_SDHCI_PXAV2
>>>        tristate "Marvell PXA168 SD Host Controller support (PXAV2)"
>>>        default CPU_PXA168
>
> change to
>>>        tristate "Marvell PXA9xx SD Host Controller support (PXAV2)"
>
> the pxa168 will not work in all cases with the V2 code.  It needs IO_ACCESSORS for readw and
> a callback to sdhci.c to delay then time between transfers.  Once V2 code is mainline
> I will resubmit the pxa168 code.
>
>
>>>
>>> config MMC_SDHCI_PXAV3
>>>        tristate "Marvell MMP2/PX9XX SD Host Controller support (PXAV3)"
>>>        default CPU_MMP2 || CPU_PXA910
>>>
>>
>> Yeah, the above is much cleaner/simpler.
>>
>>> you increase the chances of users getting the configuration right.
>>>
>>>        Arnd
>>>

Thanks for good suggestion. Will update to v4.