[PATCH 3/3] ARM: l2x0: Add OF based initialization

Olof Johansson olof at lixom.net
Tue Jun 7 12:20:30 EDT 2011

On Tue, Jun 7, 2011 at 7:22 AM, Rob Herring <robherring2 at gmail.com> wrote:

> +- aux-value : Value to set the Auxillary Control register to. Setting masked
> +  bits is undefined. Default value is 0.
> +- aux-mask : Mask of bits to preserve in the Auxillary Control register.
> +  Default value is 0xffffffff.

The device tree should describe the hardware, not the way the linux
kernel drives the hardware. In the case of the AUX register, it's
mostly a collection of options that are either turned on or off. I
don't think they should necessarily be described as an opaque 32-bit
word, but instead as separate attributes.

At least the geometry should be specified that way.

For feature enable bits, it depends on what features should be enabled
and from the kernel side. I'm not sure that belongs in the device tree
at all.


More information about the linux-arm-kernel mailing list