[PATCH v3 2/4] mmc: support sdhci-pxav2.c

Eric Miao eric.y.miao at gmail.com
Tue Jun 7 03:31:48 EDT 2011


> How about changing the title of the option though? A user will
> usually not know if he is using the v2 or v3 controller without
> reading the help text. If you change it to
>
> config MMC_SDHCI_PXAV2
>        tristate "Marvell PXA168 SD Host Controller support (PXAV2)"
>        default CPU_PXA168
>
> config MMC_SDHCI_PXAV3
>        tristate "Marvell MMP2/PX9XX SD Host Controller support (PXAV3)"
>        default CPU_MMP2 || CPU_PXA910
>

Yeah, the above is much cleaner/simpler.

> you increase the chances of users getting the configuration right.
>
>        Arnd
>
> BTW, both of you: Please always remove the lines that you don't refer to
> when you reply to an email. It's very annoying having to scroll through
> dozens of lines of citations to see what you are actually writing.
>



More information about the linux-arm-kernel mailing list