[PATCH v2 1/2] ARM: omap4: gpio: fix setting IRQWAKEN bits

Grant Likely grant.likely at secretlab.ca
Mon Jun 6 21:06:36 EDT 2011

On Mon, Jun 6, 2011 at 5:18 PM, Kevin Hilman <khilman at ti.com> wrote:
> Hi Colin,
> Colin Cross <ccross at android.com> writes:
>> Setting the IRQWAKEN bit was overwriting previous IRQWAKEN bits,
>> causing only the last bit set to take effect, resulting in lost
>> wakeups when the GPIO controller is in idle.
>> Replace direct writes to IRQWAKEN with MOD_REG_BIT calls to
>> perform a read-modify-write on the register.
>> Signed-off-by: Colin Cross <ccross at android.com>
> Thanks, I'll queue these both for Grant for the 3.0-rc fixes along with
> another GPIO fix for a section mismatch I have queued.
> Minor: now that this driver has moved to drivers, I changed the subject
> prefixes slightly.  They now read:
> GPIO: OMAP: fix setting IRQWAKEN bits for OMAP4
> GPIO: OMAP: add locking around calls to _set_gpio_triggering

If you're collecting fixes for Linus anyway, go ahead and add my a-b
line and include these two to send on to Linus

Acked-by: Grant Likely <grant.likely at secretlab.ca>

Or, if they are only gpio fixes, then I'd also be happy to get a git
pull req for the changes.  :-)


More information about the linux-arm-kernel mailing list