[PATCH v4] ARM: ep93xx: use more reliable CPLD watchdog for reset on ts72xx

Petr Štetiar ynezz at true.cz
Sun Jun 5 03:51:28 EDT 2011


Olof Johansson <olof at lixom.net> [2011-06-03 11:43:27]:

Hi,

> It would be nicer to introduce a function pointer here, that's filled
> in by the ts72xx.c machine_init function but NULL by default:

yes, I didn't liked the modification of the shared machine code either and I
personally dislike the ifdefs also, but

> Otherwise, other boards would add another if statement, any new ts72xx
> board would need to modify the soc-common header, etc.

this is very unlikely to happen. The TS's ep93xx based products seems to be
EOL, they'll just sell them until they've parts/SOC available.

I'll leave the decision up to the maintainers.

-- ynezz



More information about the linux-arm-kernel mailing list