[PATCH 2/3] davinci: dm6467/T EVM: pass reference clock rate to dm646x_init()

[Olof Johansson]

Hi,

On Fri, Jun 3, 2011 at 4:32 AM, Nori, Sekhar <nsekhar at ti.com> wrote:
> Hi Olof,
>
> On Thu, Jun 02, 2011 at 23:31:05, Olof Johansson wrote:
>
>> Do you foresee needing more members of the davinci_board_info struct
>> in the near future? If so, this approach is OK. If this is the only
>> anticipated use today, just passing in the refclk rate as an integer
>> argument would be just as clean, with less infrastructure.
>
> There was some discussion on passing PLL configuration information too.
> So yes, the structure is likely extended in future.
>
> Also, most boards end up using the reference clock used by the EVM.
> In that case, with this approach, most boards just pass NULL instead of
> replicating the reference clock frequency in all board files.

OK, that sounds reasonable.

Only change I would like to request in that case (sorry, not
commenting on the patch directly here), is to mark dm646x_evm
__initdata (or even make it a local variable in the function), so for
multiboard kernels you won't need to keep the static struct around for
hardware you're not running on.


-Olof