[PATCH] arm: fix lockdep warning of "unannotated irqs-off"

Ming Lei ming.lei at canonical.com
Wed Jun 1 10:28:29 EDT 2011


Hi,

On Wed, 1 Jun 2011 14:22:33 +0100
Russell King - ARM Linux <linux at arm.linux.org.uk> wrote:

> From: Russell King - ARM Linux <linux at arm.linux.org.uk>

> If CONFIG_IRQSOFF_TRACER is not set, we don't bother telling the
> tracer that we've turned IRQs on for userspace when we exit from the
> kernel, and we don't bother telling the tracer that we've turned IRQs
> off when entering from userspace back into the kernel.
> 
> So, making this depend on CONFIG_TRACE_IRQFLAGS looks wrong to me.

From lib/Kconfig.debug:

	config PROVE_LOCKING
		bool "Lock debugging: prove locking correctness"
		......
		select TRACE_IRQFLAGS

you can find locking prove does need to enable TRACE_IRQFLAGS. Meantime,
we may not enable irq off tracer via below:
	
	Kernel hacking  --->
		Tracers  --->
			[ ]   Interrupts-off Latency Tracer	

so making this depend on CONFIG_TRACE_IRQFLAGS is reasonable.

thanks,
--
Ming Lei



More information about the linux-arm-kernel mailing list