[PATCH] arm: fix lockdep warning of "unannotated irqs-off"

Ming Lei ming.lei at canonical.com
Wed Jun 1 09:17:51 EDT 2011


Hi,

On Wed, 1 Jun 2011 10:34:36 +0100
Russell King - ARM Linux <linux at arm.linux.org.uk> wrote:

> On Wed, Jun 01, 2011 at 03:42:59PM +0800, Ming Lei wrote:
> > @@ -435,6 +435,10 @@ __irq_usr:
> >  	usr_entry
> >  	kuser_cmpxchg_check
> >  
> > +#ifdef CONFIG_TRACE_IRQFLAGS
> 
> I think this wants to be CONFIG_IRQSOFF_TRACER.

IMO, this should be CONFIG_TRACE_IRQFLAGS because we
want to trace interrupt disable and enable here, but
enabling CONFIG_IRQSOFF_TRACER means interrupt-off
latency tracer will be switched on, see kernel/trace/Kconfig.

--
Ming Lei



More information about the linux-arm-kernel mailing list