[PATCH 09/18] dmaengine/amba-pl08x: Schedule tasklet in case of error interrupt

viresh kumar viresh.linux at gmail.com
Sun Jul 31 01:33:05 EDT 2011


On 7/30/11, Linus Walleij <linus.walleij at linaro.org> wrote:
> 2011/7/29 Viresh Kumar <viresh.kumar at st.com>:
> NAK.
>
> These snippets illustrate what is not good about this patch, you're making
> the driver fragile by removing checks for spurious IRQ.
>
> So for example if there is an error or TC IRQ on a channel that is not
> in use, what happens now?
>
> It used to result in IRQ_NONE, now all of a sudden we start handling
> spurious IRQs and claim IRQ_HANDLED with totally unpredictable
> results, whereas they would previously gather error metrics for
> spurious IRQs.
>

I got your point. Will resend this patch with better handling for
spurious interrupts.

--
viresh



More information about the linux-arm-kernel mailing list