[PATCH 06/18] dmaengine/amba-pl08x: Simplify pl08x_ensure_on()

Linus Walleij linus.walleij at linaro.org
Sat Jul 30 18:36:14 EDT 2011


2011/7/29 Viresh Kumar <viresh.kumar at st.com>:

> Simply writing 1 on bit 0 is sufficient instead of reading and clearing bits.
> Also as per manual, for bit 3-31 of DMACConfiguration register:
> "read undefined, write as 0"
>
> So, we must not rely on values read from this registers bit 3-31.
>
> Signed-off-by: Viresh Kumar <viresh.kumar at st.com>

Obviously correct,
Acked-by: Linus Walleij <linus.walleij at linaro.org>

Thanks,
Linus Walleij



More information about the linux-arm-kernel mailing list