[PATCH 02/18] dmaengine/amba-pl08x: Resolve formatting issues
viresh kumar
viresh.linux at gmail.com
Fri Jul 29 11:25:09 EDT 2011
On 7/29/11, Koul, Vinod <vinod.koul at intel.com> wrote:
> On Fri, 2011-07-29 at 16:19 +0530, Viresh Kumar wrote:
>> /*
>> * So now we know how many bytes to transfer
>> - * to get to the nearest boundary. The next
>> - * LLI will past the boundary. However, we
>> + * to get to the nearest boundary. The next
>> + * LLI will past the boundary. However, we
>> * may be working to a boundary on the slave
>> - * bus. We need to ensure the master stays
>> + * bus. We need to ensure the master stays
>> * aligned, and that we are working in
>> * multiples of the bus widths.
>> */
> This looks v ugly, care to fix this.
> 80chars should be followed with a little common sense, if it sacrifices
> code readability then pls ignore it.
> In places where you can fix it w/o sacrificing code quality pls do it :)
Ok.
>> /* FIXME: use round_down()? */
> while you are fixing the driver, care to fix the FIXME as well?
Already removed this. :)
--
viresh
More information about the linux-arm-kernel
mailing list