[PATCH 2/3] arch: arm: mach-cns3xxx: Add gpiolib support
Russell King - ARM Linux
linux at arm.linux.org.uk
Thu Jul 28 06:04:44 EDT 2011
On Fri, Jul 29, 2011 at 01:16:41AM +0800, Tommy Lin wrote:
> +#include <linux/platform_device.h>
> +#include <linux/proc_fs.h>
> +#include <linux/io.h>
> +
> +#include <mach/gpio.h>
Come on guys, you absolutely deserve your code to break as you're
continuing to include mach/gpio.h directly, even after I've said
I'm going to be moving stuff out of mach/gpio.h into asm/gpio.h...
> +#include <asm-generic/gpio.h>
> +
> +#define gpio_get_value __gpio_get_value
> +#define gpio_set_value __gpio_set_value
> +#define gpio_cansleep __gpio_cansleep
> +#define gpio_to_irq __gpio_to_irq
Oh look, yet another identical implementation to add to the list...
(it's this stuff which I'm moving after this merge window.)
Please, make sure you include linux/gpio.h and not mach/gpio.h.
More information about the linux-arm-kernel
mailing list