[PATCH v3 0/6] ARM: mx28: add usb host function

[Marc Kleine-Budde]

On 07/27/2011 07:29 AM, Tony Lin wrote:
> this patch series is to add mx28 usb host function.
> the driver only support usb host mode on usb port1.
> the driver reuses ehci-mxc.c under usb/host, but add
> platform irq handler routines if platform wants to 
> do something specific in irq handler.
> the patch also consolidates some macro definitions
> and structure definitions to make ehci-mxc.c better
> reusable among mxs/mxc platforms.
> 
> Code is based on the branch for-next in sascha's tree http://git.pengutronix.de/git/imx/linux-2.6.git
> 
> Tested on MX28 EVK.
> 
> changes since v2:
>  * add error condition clean up code.
>  * remove unnecessary initial code.
>  * change file name from regs-usbphy-mx28 to regs-usbphy-mxs.h.
> 
> changes since v1:
>  * add dummy clock to avoid adding cpu judgement in driver for Sascha's request.

What about providing dummy clock definitions to the mxc's that don't
have the clocks, too. This way you can remove all the cpu_is from
"drivers/usb/host/ehci-mxc.c". You don't have to add all cpu_is_mx* to
your "arch/arm/mach-mxs/include/mach/mxs.h".

>  * use context in phy functions, so that usb device could share the code.
>  * some code consolidation and patch reorgnization.
>  * error checking improvement.
>  * remove a few unneccesary code.
> 
> Tony Lin (6):
>   ARM: mxs: ehci: consolidate definitions and structures to share among platforms
>   ARM: mxs: enable usb1 phy power supply
>   ARM: mxs: add usb clocks to clock tree
>   ARM: mxs: make ehci-mxc more flexible to be used on different platforms
>   ARM: mxs: add usb phy operations
>   ARM: mxs: add usb host function to default config
> 
>  arch/arm/configs/mxs_defconfig            |    8 +-
>  arch/arm/mach-mxs/Kconfig                 |    1 +
>  arch/arm/mach-mxs/Makefile                |    1 +
>  arch/arm/mach-mxs/clock-mx28.c            |   16 ++-
>  arch/arm/mach-mxs/include/mach/hardware.h |    2 +
>  arch/arm/mach-mxs/include/mach/mxs.h      |   12 +-
>  arch/arm/mach-mxs/mach-mx28evk.c          |    8 +
>  arch/arm/mach-mxs/mxs_usb.c               |  288 +++++++++++++++++++++++++++++
>  arch/arm/mach-mxs/regs-usbphy-mxs.h       |  240 ++++++++++++++++++++++++
>  arch/arm/plat-mxc/include/mach/mxc_ehci.h |   19 --
>  drivers/usb/host/Kconfig                  |    2 +-
>  drivers/usb/host/ehci-mxc.c               |   19 ++-
>  include/linux/fsl_devices.h               |   21 ++
>  13 files changed, 609 insertions(+), 28 deletions(-)
>  create mode 100644 arch/arm/mach-mxs/mxs_usb.c
>  create mode 100644 arch/arm/mach-mxs/regs-usbphy-mxs.h
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

cheers, Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110727/5105717c/attachment.sig>