[PATCH V2 5/7] ARM: S5P64X0: Add file to hold common Framebuffer and LCD code

Russell King - ARM Linux linux at arm.linux.org.uk
Tue Jul 26 04:00:52 EDT 2011


On Mon, Jul 25, 2011 at 04:00:23PM -0400, Ajay Kumar wrote:
> diff --git a/arch/arm/mach-s5p64x0/Kconfig b/arch/arm/mach-s5p64x0/Kconfig
> index 4fee745..ed87151 100644
> --- a/arch/arm/mach-s5p64x0/Kconfig
> +++ b/arch/arm/mach-s5p64x0/Kconfig
> @@ -32,6 +32,11 @@ config S5P64X0_SETUP_I2C1
>  	help
>  	  Common setup code for i2c bus 1.
>  
> +config COMMON_FB

This is a very bad config name.  It's specific to a group of SoCs but it
seems to be advertising itself as something which isn't.  What if
drivers/video/Kconfig gets a COMMON_FB symbol too?



More information about the linux-arm-kernel mailing list