[PATCH v2 3/6] ARM: mxs: add usb clocks to clock tree

[Lin Tony-B19295]

> -----Original Message-----
> From: Sergei Shtylyov [mailto:sshtylyov at mvista.com]
> Sent: Monday, July 25, 2011 6:24 PM
> To: Lin Tony-B19295
> Cc: linux-usb at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> stern at rowland.harvard.edu; koen.beel.barco at gmail.com
> Subject: Re: [PATCH v2 3/6] ARM: mxs: add usb clocks to clock tree
> 
> Hello.
> 
> On 25-07-2011 11:01, Tony Lin wrote:
> 
> > add usb host clock and usb host phy clock to clock tree add usb dummy
> > clocks to clock tree to get rid of adding more cpu_is_mx macros
> 
> > Signed-off-by: Tony Lin<tony.lin at freescale.com>
> > ---
> >   arch/arm/mach-mxs/clock-mx28.c |   28 +++++++++++++++++++---------
> >   1 files changed, 19 insertions(+), 9 deletions(-)
> 
> > diff --git a/arch/arm/mach-mxs/clock-mx28.c
> > b/arch/arm/mach-mxs/clock-mx28.c index 5dcc59d..6f3cd40 100644
> > --- a/arch/arm/mach-mxs/clock-mx28.c
> > +++ b/arch/arm/mach-mxs/clock-mx28.c
> > @@ -554,15 +554,15 @@ static struct clk rtc_clk = {
> >   	.parent =&ref_xtal_clk,
> >   };
> >
> > -/* usb_clk gate is controlled in DIGCTRL other than CLKCTRL */
> > -static struct clk usb0_clk = {
> > -	.enable_reg = DIGCTRL_BASE_ADDR,
> > -	.enable_shift = 2,
> > -	.enable = _raw_clk_enable,
> > -	.disable = _raw_clk_disable,
> > -	.parent =&pll0_clk,
> > +static struct clk dummy_clk = {
> > +	.enable_reg = 0,
> > +	.enable_shift = 0,
> > +	.enable = NULL,
> > +	.disable = NULL,
> > +	.parent = NULL,
> 
>     You don't need to explicitly initialize to 0 or NULL.
> 
Okay.

> WBR, Sergei