[patch 1/3] imx51: add pata device
Arnaud Patard (Rtp)
arnaud.patard at rtp-net.org
Fri Jul 22 16:28:49 EDT 2011
Uwe Kleine-König <u.kleine-koenig at pengutronix.de> writes:
> On Fri, Jul 22, 2011 at 12:14:15PM -0300, Fabio Estevam wrote:
>> On Fri, Jul 22, 2011 at 7:37 AM, Arnaud Patard
>> <arnaud.patard at rtp-net.org> wrote:
>> ...
>> > +#define imx_mxc_pata_data_entry_single(soc) \
>> > + { \
>> > + .iobase = soc ## _ATA_BASE_ADDR, \
>> > + .irq = soc ## _MXC_INT_ATA, \
>>
>> Why not imx_pata_data_entry_single instead?
>>
>> "imx_mxc" looks redundant.
> imx is the platform prefix, mxc_pata the device's name. So IMHO the name
> is right and consistent with the other device registration stuff.
More information about the linux-arm-kernel
mailing list