[PATCH] OMAP: omap_device: replace pr_* prints with dev_*

Kevin Hilman khilman at ti.com
Fri Jul 22 15:51:06 EDT 2011


Grazvydas Ignotas <notasas at gmail.com> writes:

> On Thu, Jul 21, 2011 at 8:39 PM, Kevin Hilman <khilman at ti.com> wrote:
>>                if (act_lat > odpl->activate_lat) {
>>                        odpl->activate_lat_worst = act_lat;
>>                        if (odpl->flags & OMAP_DEVICE_LATENCY_AUTO_ADJUST) {
>>                                odpl->activate_lat = act_lat;
>> -                               pr_warning("omap_device: %s.%d: new worst case "
>> -                                          "activate latency %d: %llu\n",
>> -                                          od->pdev.name, od->pdev.id,
>> -                                          od->pm_lat_level, act_lat);
>> +                               dev_warn(&od->pdev.dev,
>> +                                        "new worst case activate latency "
>> +                                        "%d: %llu\n",
>> +                                        od->pm_lat_level, act_lat);
>
> I wonder why these have to be warnings, I get quite a lot of them and
> find them rather annoying. Or is my hardware broken or something?

No, your hardware is not broken.

> I know other people are disabling this in their trees too:
> http://www.sakoman.com/cgi-bin/gitweb.cgi?p=linux-omap-2.6.git;a=commitdiff;h=145cf9a7d4ba7c260df7071a28ef40c6a481b6df

Patches to change that are welcome on the list.  

It's not related to this patch which just changes from pr_warning to
dev_warn, so needs to be done in a separate patch.

Kevin


More information about the linux-arm-kernel mailing list