On Fri, Jul 22, 2011 at 7:37 AM, Arnaud Patard <arnaud.patard at rtp-net.org> wrote: ... > +#define imx_mxc_pata_data_entry_single(soc) \ > + { \ > + .iobase = soc ## _ATA_BASE_ADDR, \ > + .irq = soc ## _MXC_INT_ATA, \ Why not imx_pata_data_entry_single instead? "imx_mxc" looks redundant. Regards, Fabio Estevam