[PATCH v2] ARM: Tegra: Trimslice: Tri-state DAP3 pinmux

Stephen Warren swarren at nvidia.com
Thu Jul 21 11:33:31 EDT 2011


Mike Rapoport wrote at Thursday, July 21, 2011 3:17 AM:
> On Thu, Jul 21, 2011 at 10:10 AM, Mike Rapoport <mike.rapoport at gmail.com> wrote:
> >> DAP3 is used for a bunch of GPIOs. Not tri-stating the pins means audio
> >> signals get sent out there, and this ends up resetting USB and breaking
> >> SDHCI too.
> >>
> >> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> >> ---
> >> v2: s/DAP2/DAP3/ in patch subject/description.
> >
> > Setting DAP3 pins to tristate is necessary but not sufficient :) I
> > don't know why, but if we don't tristate DAP2 and DAP4 as well USB and
> > SDIO are broken.
> > If you can amend your patch with tristating also DAP2 and DAP4 feel
> > free to add my
> 
> Oops, I should have read the diff context as well... DAP{2,4} are
> anyway tristate, so you can discard my previous comment. So the
> Acked-by applies to the original patch. Sorry for the noise.
> 
> > Acked-by: Mike Rapoport <mike at compulab.co.il>

Thanks! Note that Arnd already picked this patch up in arm-soc.git.

-- 
nvpublic




More information about the linux-arm-kernel mailing list