[PATCH 1/1] ARM: mxs-dma: reset after disable channel

[Wolfram Sang]

On Tue, Jul 19, 2011 at 04:45:37PM +0800, Shawn Guo wrote:
> On Tue, Jul 19, 2011 at 10:21:46AM +0200, Wolfram Sang wrote:
> > On Tue, Jul 19, 2011 at 12:02:16PM +0800, Shawn Guo wrote:
> > > On Tue, Jul 19, 2011 at 12:09:56PM +0800, Dong Aisheng wrote:
> > > > We met some channels in abnormal state after disable.
> > > > Reset it to get a clean state.
> > > > 
> > > > Signed-off-by: Dong Aisheng <b29396 at freescale.com>
> > > > Cc: Vinod Koul <vinod.koul at intel.com>
> > > > Cc: Shawn Guo <shawn.guo at linaro.org>
> > > > ---
> > > 
> > > Acked-by: Shawn Guo <shawn.guo at linaro.org>
> > 
> > Just to make sure: Did you investigate where the "abnormal" state came
> > from and if that could be fixed?
> > 
> I suppose this is a question for Aisheng, as he is the one who actually
> saw the "abnormal" state.  

OK.

> But since mxs_dma_disable_chan() is being
> called in mxs_dma_control(DMA_TERMINATE_ALL) for case audio, it's should
> be pretty safe reset the channel here.

It might be safe but can still hide the real bug ;)

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110719/601fe800/attachment.sig>