[PATCH 4/7] at91: remove non used at91_spi.h

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Fri Jul 15 11:46:36 EDT 2011


On 13:47 Fri 15 Jul     , Detlef Vollmann wrote:
> Sorry, I couldn't find a summary message for this patch series,
> so I picked this one to reply, because this one hurts me most.
> 
> On 07/15/11 01:52, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD<plagnioj at jcrosoft.com>
> > Cc: Nicolas Ferre<nicolas.ferre at atmel.com>
> > ---
> >   arch/arm/mach-at91/include/mach/at91_spi.h |   81
> ----------------------------
> >   1 files changed, 0 insertions(+), 81 deletions(-)
> >   delete mode 100644 arch/arm/mach-at91/include/mach/at91_spi.h
> [...]
> 
> First, I'm actually using mach/at91_spi.h in an SPI slave driver.
> And I'm using arch/arm/mach-at91/include/mach/at91_spi.h instead of
> drivers/spi/atmel_spi.h (which still exists in the kernel version
> we use here), because arch/arm/mach-at91/include/mach/at91_spi.h
> is accessible from an out-of-tree driver w/o extra effort.
> 
> And this applies to all all of those header files, so I'm
> really against all patches in this series.
You need the use SPI framework for this

Out of tree driver is not enough good reason to keep it

Best Regards,
J.



More information about the linux-arm-kernel mailing list