[PATCH 19/51] ARM: kprobes: Infrastructure for table driven decoding of CPU instructions

Tixy tixy at yxit.co.uk
Tue Jul 12 03:14:01 EDT 2011


On Mon, 2011-07-11 at 16:05 -0400, Nicolas Pitre wrote:
> On Sat, 9 Jul 2011, Tixy wrote:
> 
> > +static kprobe_opcode_t __kprobes
> > +prepare_emulated_insn(kprobe_opcode_t insn, struct arch_specific_insn *asi,
> > +								bool thumb)
> > +{
> > +#ifdef CONFIG_THUMB2_KERNEL
> > +	if (thumb) {
> > +		u16* thumb_insn = (u16 *)asi->insn;
> 
> Ninor style nit: we usually put the * against the variable rather than 
> the type.

checkpatch doesn't catch that one. I'll try and come up with a
simplified test case for a bug report.

-- 
Tixy




More information about the linux-arm-kernel mailing list