[PATCH 05/17] mach-ks8695: remove leds driver, since nobody use it

Bryan Wu bryan.wu at canonical.com
Mon Jul 11 10:07:46 EDT 2011


On Mon, Jul 11, 2011 at 10:00 PM, Nicolas Pitre
<nicolas.pitre at linaro.org> wrote:
> On Mon, 11 Jul 2011, Bryan Wu wrote:
>
>> On Mon, Jul 11, 2011 at 7:11 PM, Sergei Shtylyov <sshtylyov at mvista.com> wrote:
>> > Hello.
>> >
>> > On 09-07-2011 0:23, Andrew Victor wrote:
>> >
>> >>> Signed-off-by: Bryan Wu<bryan.wu at canonical.com>
>> >
>> >> As the original author of this code.
>> >
>> >> Acked-by: Andrew Victor <linux at maxim.org.za>
>> >
>> >   If you're the original author, shouldn't there be:
>> >
>> > From: Andrew Victor <linux at maxim.org.za>
>> >
>>
>> No problem, I will change that.
>
> Beware.  Is Andrew Victor the original author of the code being removed
> here and in this case he's indicating his agreement to the removal of
> his code, or he is the one actually responsible for the removal?  If the
> former then it is wrong to put a "From" with his name and the
> "Acked-by:" is the right thing to do.
>

Right, I was confused by the email. I prepared the removing patch and
Andrew said "Acked-by".
Andrew, is that what you want?

Thanks,
-- 
Bryan Wu <bryan.wu at canonical.com>
Kernel Developer    +86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com



More information about the linux-arm-kernel mailing list