[PATCH 1/2] arch: arm: Correct the dependency of HAVE_ARM_TWD

[Russell King - ARM Linux]

On Fri, Jul 08, 2011 at 01:10:14PM +0400, Anton Vorontsov wrote:
> On Fri, Jul 08, 2011 at 01:59:23PM +0800, Tommy Lin wrote:
> > Original mpcore_wdt config dependency is as follow:
> > MPCORE_WATCHDOG -> HAVE_ARM_TWD -> SMP -> (CPU_V6K || CPU_V7)
> > This patch will remove SMP and made the dependency as follow:
> > MPCORE_WATCHDOG -> HAVE_ARM_TWD -> (CPU_V6K || CPU_V7)
> > 
> > The MPCore watchdog (and timer) can be found at ARM11 MPCore (CPU_V6K) and
> > Cortex A9 MPCore (CPU_V7). The dependency between MPCORE_WATCHDOG and
> > (CPU_V6K || CPUV7) is necessary, but the dependency of SMP is redundant.
> > The MPCore watchdog should function normally even SMP is not turned on with
> > ARM11 or Cortex A9 CPU.
> > 
> > Signed-off-by: Tommy Lin <tommy.lin at caviumnetworks.com>
> > ---
> 
> Russell,
> 
> As the patch is needed for CNS3xxx Watchdog support, I'd like to take
> it via CNS3xxx tree, if you're OK with that.

No.

TWD is only useful if SMP is enabled, otherwise the contained code
won't be called.  Without SMP you'll find that the timer rate will
be zero.

So actually your problems are bigger than just this dependency.