[PATCH 2/7] DMA: PL330: Update PL330 DMA API driver
Kukjin Kim
kgene.kim at samsung.com
Fri Jul 8 03:57:27 EDT 2011
Russell King - ARM Linux wrote:
>
> On Mon, Jul 04, 2011 at 09:18:30PM +0900, Kukjin Kim wrote:
> > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> > index 25cf327..9b7f15a 100644
> > --- a/drivers/dma/Kconfig
> > +++ b/drivers/dma/Kconfig
> > @@ -193,7 +193,8 @@ config ARCH_HAS_ASYNC_TX_FIND_CHANNEL
> > config PL330_DMA
> > tristate "DMA API Driver for PL330"
> > select DMA_ENGINE
> > - depends on PL330
> > + select ARM_AMBA
>
> This is the wrong way around. If your SoC supports Primecells, then you
are
> supposed to select ARM_AMBA from the SoC to allow the Primecell drivers to
be
> enabled. Primecell drivers should then depend on ARM_AMBA.
OK, will address comments.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
More information about the linux-arm-kernel
mailing list