reply: [PATCH v5 1/3] ARM: mxs: add GPMI-NFC support for?imx23/imx28

[Arnd Bergmann]

On Thursday 07 July 2011 22:48:33 Uwe Kleine-König wrote:
> My thoughts on this is that it should better go to where struct resource
> is defined (<linux/ioports.h>, as Arndt suggested) but then probably a
> bit more generic as:
> 
>         #define RES_MEM_NAMED(_start, _end, _name)                      \
>                 {                                                       \
>                         .start = _start,                                \
>                         .end = _end,                                    \
>                         .name = _name,                                  \
>                         .flags = IORESOURCE_MEM,                        \
>                 }
>         #define RES_MEM(_start, _end)                                   \
>                 RES_MEM_NAMED(_start, _end, NULL)
> 
> (Maybe alternatively take a _size parameter instead of _end?)
> While this makes the repetition shorter, it's still there.
> 

This sounds reasonable, and I'd also prefer the size instead of end
argument here. If you prepare a patch to do this, I can ack it for you.

	Arnd