[PATCH 00/17] Introduce a led trigger for CPU activity

Eric Miao eric.y.miao at gmail.com
Wed Jul 6 09:19:43 EDT 2011


On Wed, Jul 6, 2011 at 9:16 PM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Wed, Jul 06, 2011 at 09:13:14PM +0800, Eric Miao wrote:
>> >  drivers/leds/ledtrig-cpu.c                     |  144 ++++++++++++
>> >  include/linux/leds.h                           |   15 ++
>> >  105 files changed, 1532 insertions(+), 3119 deletions(-)
>>
>> Not bad, I like the numbers here. This is definitely a good move.
>> I had long ago wanted to remove those legacy LED code in mach-pxa.
>
> The down-side is that through these moves we've lost functionality each
> time.  For example, the blinking heartbeat LED on the Assabet and
> Netwinder which I always enabled to let me know whether the machines
> were still alove has long since gone.
>
> I hope that this series restores that functionality on those platforms
> where it has been lost.
>

Yeah, I have the same concern. So probably extending the current simple
API to allow a more flexible behavior would be better.



More information about the linux-arm-kernel mailing list