[PATCH 5/7] ARM: EXYNOS4: Use generic DMA PL330 driver
Alim Akhtar
alim.akhtar at gmail.com
Tue Jul 5 02:07:00 EDT 2011
On Mon, Jul 4, 2011 at 5:48 PM, Kukjin Kim <kgene.kim at samsung.com> wrote:
>
> From: Boojin Kim <boojin.kim at samsung.com>
>
> This patch makes EXYNOS4 use DMA PL330 driver on DMADEVICE.
> EXYNOS4 uses DMA generic API instead of SAMSUNG specific S3C-PL330 API.
>
> Signed-off-by: Boojin Kim <boojin.kim at samsung.com>
> Signed-off-by: Kukjin Kim <kgene.kim at samsung.com>
> ---
> arch/arm/mach-exynos4/Kconfig | 2 +-
> arch/arm/mach-exynos4/clock.c | 16 +-
> arch/arm/mach-exynos4/dma.c | 323 +++++++++++++++++++++++++++--------------
> 3 files changed, 221 insertions(+), 120 deletions(-)
>
> diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig
> index 1435fc3..5cc9b7a 100644
> --- a/arch/arm/mach-exynos4/Kconfig
> +++ b/arch/arm/mach-exynos4/Kconfig
> @@ -11,7 +11,7 @@ if ARCH_EXYNOS4
>
> config CPU_EXYNOS4210
> bool
> - select S3C_PL330_DMA
> + select DMADEV_PL330
> help
> Enable EXYNOS4210 CPU support
>
> diff --git a/arch/arm/mach-exynos4/clock.c b/arch/arm/mach-exynos4/clock.c
> index 871f9d5..1b2e78c 100644
> --- a/arch/arm/mach-exynos4/clock.c
> +++ b/arch/arm/mach-exynos4/clock.c
> @@ -47,6 +47,11 @@ static struct clk clk_sclk_usbphy1 = {
> .id = -1,
> };
>
> +static struct clk dummy_apb_pclk = {
> + .name = "apb_pclk",
> + .id = -1,
> +};
> +
What is the need to creating "dummy_apb_pclk" ?
>
> static int exynos4_clksrc_mask_top_ctrl(struct clk *clk, int enable)
> {
> return s5p_gatectrl(S5P_CLKSRC_MASK_TOP, clk, enable);
> @@ -485,16 +490,11 @@ static struct clk init_clocks_off[] = {
> .enable = exynos4_clk_ip_fsys_ctrl,
> .ctrlbit = (1 << 10),
> }, {
> - .name = "pdma",
> - .id = 0,
> + .name = "dma",
> + .id = -1,
Cannot this "dma" clock be used as apb_pclk clock?
Why not use the _clkdev_, that will resolve the issues dealing with 2
instances of DMA driver (pdma0 and pdma1)?
That will be needed once you register the exynos4_device_pdma1 as amba_device.
>
> .enable = exynos4_clk_ip_fsys_ctrl,
> .ctrlbit = (1 << 0),
> }, {
> - .name = "pdma",
> - .id = 1,
> - .enable = exynos4_clk_ip_fsys_ctrl,
> - .ctrlbit = (1 << 1),
> - }, {
> .name = "adc",
> .id = -1,
> .enable = exynos4_clk_ip_peril_ctrl,
> @@ -1212,5 +1212,7 @@ void __init exynos4_register_clocks(void)
> s3c_register_clocks(init_clocks_off, ARRAY_SIZE(init_clocks_off));
> s3c_disable_clocks(init_clocks_off, ARRAY_SIZE(init_clocks_off));
>
> + s3c24xx_register_clock(&dummy_apb_pclk);
> +
> s3c_pwmclk_init();
> }
> diff --git a/arch/arm/mach-exynos4/dma.c b/arch/arm/mach-exynos4/dma.c
> index 564bb53..f81c6f1 100644
> --- a/arch/arm/mach-exynos4/dma.c
> +++ b/arch/arm/mach-exynos4/dma.c
> @@ -21,151 +21,250 @@
> * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> */
>
> -#include <linux/platform_device.h>
> #include <linux/dma-mapping.h>
>
> +#include <linux/amba/bus.h>
> +#include <linux/amba/pl330.h>
> +#include <asm/irq.h>
> #include <plat/devs.h>
> #include <plat/irqs.h>
>
> #include <mach/map.h>
> #include <mach/irqs.h>
> -
> -#include <plat/s3c-pl330-pdata.h>
> +#include <mach/dma.h>
>
> static u64 dma_dmamask = DMA_BIT_MASK(32);
>
> -static struct resource exynos4_pdma0_resource[] = {
> - [0] = {
> - .start = EXYNOS4_PA_PDMA0,
> - .end = EXYNOS4_PA_PDMA0 + SZ_4K,
> - .flags = IORESOURCE_MEM,
> - },
> - [1] = {
> - .start = IRQ_PDMA0,
> - .end = IRQ_PDMA0,
> - .flags = IORESOURCE_IRQ,
> +struct dma_pl330_peri pdma0_peri[32] = {
> + {
> + .peri_id = (u8)DMACH_PCM0_RX,
> + .rqtype = DEVTOMEM,
> + }, {
> + .peri_id = (u8)DMACH_PCM0_TX,
> + .rqtype = MEMTODEV,
> + }, {
> + .peri_id = (u8)DMACH_PCM2_RX,
> + .rqtype = DEVTOMEM,
> + }, {
> + .peri_id = (u8)DMACH_PCM2_TX,
> + .rqtype = MEMTODEV,
> + .burst_sz = 4,
> + }, {
> + .peri_id = (u8)DMACH_MSM_REQ0,
> + }, {
> + .peri_id = (u8)DMACH_MSM_REQ2,
> + }, {
> + .peri_id = (u8)DMACH_SPI0_RX,
> + .rqtype = DEVTOMEM,
> + .burst_sz = 1,
> + }, {
> + .peri_id = (u8)DMACH_SPI0_TX,
> + .rqtype = MEMTODEV,
> + .burst_sz = 1,
> + }, {
> + .peri_id = (u8)DMACH_SPI2_RX,
> + .rqtype = DEVTOMEM,
> + .burst_sz = 1,
> + }, {
> + .peri_id = (u8)DMACH_SPI2_TX,
> + .rqtype = MEMTODEV,
> + .burst_sz = 1,
> + }, {
> + .peri_id = (u8)DMACH_I2S0S_TX,
> + .rqtype = MEMTODEV,
> + }, {
> + .peri_id = (u8)DMACH_I2S0_RX,
> + .rqtype = DEVTOMEM,
> + }, {
> + .peri_id = (u8)DMACH_I2S0_TX,
> + .rqtype = MEMTODEV,
> + }, {
> + .peri_id = (u8)DMACH_UART0_RX,
> + .rqtype = DEVTOMEM,
> + .burst_sz = 4,
> + }, {
> + .peri_id = (u8)DMACH_UART0_TX,
> + .rqtype = MEMTODEV,
> + .burst_sz = 4,
> + }, {
> + .peri_id = (u8)DMACH_UART2_RX,
> + .rqtype = DEVTOMEM,
> + .burst_sz = 4,
> + }, {
> + .peri_id = (u8)DMACH_UART2_TX,
> + .rqtype = MEMTODEV,
> + .burst_sz = 4,
> + }, {
> + .peri_id = (u8)DMACH_UART4_RX,
> + .rqtype = DEVTOMEM,
> + .burst_sz = 4,
> + }, {
> + .peri_id = (u8)DMACH_UART4_TX,
> + .rqtype = MEMTODEV,
> + .burst_sz = 4,
> + }, {
> + .peri_id = (u8)DMACH_SLIMBUS0_RX,
> + .rqtype = DEVTOMEM,
> + }, {
> + .peri_id = (u8)DMACH_SLIMBUS0_TX,
> + .rqtype = MEMTODEV,
> + }, {
> + .peri_id = (u8)DMACH_SLIMBUS2_RX,
> + .rqtype = DEVTOMEM,
> + }, {
> + .peri_id = (u8)DMACH_SLIMBUS2_TX,
> + .rqtype = MEMTODEV,
> + }, {
> + .peri_id = (u8)DMACH_SLIMBUS4_RX,
> + .rqtype = DEVTOMEM,
> + }, {
> + .peri_id = (u8)DMACH_SLIMBUS4_TX,
> + .rqtype = MEMTODEV,
> + }, {
> + .peri_id = (u8)DMACH_AC97_MICIN,
> + .rqtype = DEVTOMEM,
> + .burst_sz = 4,
> + }, {
> + .peri_id = (u8)DMACH_AC97_PCMIN,
> + .rqtype = DEVTOMEM,
> + .burst_sz = 4,
> + }, {
> + .peri_id = (u8)DMACH_AC97_PCMOUT,
> + .rqtype = MEMTODEV,
> + .burst_sz = 4,
> },
> };
>
> -static struct s3c_pl330_platdata exynos4_pdma0_pdata = {
> - .peri = {
> - [0] = DMACH_PCM0_RX,
> - [1] = DMACH_PCM0_TX,
> - [2] = DMACH_PCM2_RX,
> - [3] = DMACH_PCM2_TX,
> - [4] = DMACH_MSM_REQ0,
> - [5] = DMACH_MSM_REQ2,
> - [6] = DMACH_SPI0_RX,
> - [7] = DMACH_SPI0_TX,
> - [8] = DMACH_SPI2_RX,
> - [9] = DMACH_SPI2_TX,
> - [10] = DMACH_I2S0S_TX,
> - [11] = DMACH_I2S0_RX,
> - [12] = DMACH_I2S0_TX,
> - [13] = DMACH_I2S2_RX,
> - [14] = DMACH_I2S2_TX,
> - [15] = DMACH_UART0_RX,
> - [16] = DMACH_UART0_TX,
> - [17] = DMACH_UART2_RX,
> - [18] = DMACH_UART2_TX,
> - [19] = DMACH_UART4_RX,
> - [20] = DMACH_UART4_TX,
> - [21] = DMACH_SLIMBUS0_RX,
> - [22] = DMACH_SLIMBUS0_TX,
> - [23] = DMACH_SLIMBUS2_RX,
> - [24] = DMACH_SLIMBUS2_TX,
> - [25] = DMACH_SLIMBUS4_RX,
> - [26] = DMACH_SLIMBUS4_TX,
> - [27] = DMACH_AC97_MICIN,
> - [28] = DMACH_AC97_PCMIN,
> - [29] = DMACH_AC97_PCMOUT,
> - [30] = DMACH_MAX,
> - [31] = DMACH_MAX,
> - },
> +struct dma_pl330_platdata exynos4_pdma0_pdata = {
> + .nr_valid_peri = 32,
> + .peri = pdma0_peri,
> };
>
> -static struct platform_device exynos4_device_pdma0 = {
> - .name = "s3c-pl330",
> - .id = 0,
> - .num_resources = ARRAY_SIZE(exynos4_pdma0_resource),
> - .resource = exynos4_pdma0_resource,
> - .dev = {
> +struct amba_device exynos4_device_pdma0 = {
> + .dev = {
> + .init_name = "dma-pl330",
> .dma_mask = &dma_dmamask,
> .coherent_dma_mask = DMA_BIT_MASK(32),
> .platform_data = &exynos4_pdma0_pdata,
> - },
> + },
> + .res = {
> + .start = EXYNOS4_PA_PDMA0,
> + .end = EXYNOS4_PA_PDMA0 + SZ_4K,
> + .flags = IORESOURCE_MEM,
> + },
> + .irq = {IRQ_PDMA0, NO_IRQ},
> + .periphid = 0x00041330,
> };
>
> -static struct resource exynos4_pdma1_resource[] = {
> - [0] = {
> - .start = EXYNOS4_PA_PDMA1,
> - .end = EXYNOS4_PA_PDMA1 + SZ_4K,
> - .flags = IORESOURCE_MEM,
> - },
> - [1] = {
> - .start = IRQ_PDMA1,
> - .end = IRQ_PDMA1,
> - .flags = IORESOURCE_IRQ,
> +struct dma_pl330_peri pdma1_peri[32] = {
> + {
> + .peri_id = (u8)DMACH_PCM0_RX,
> + .rqtype = DEVTOMEM,
> + }, {
> + .peri_id = (u8)DMACH_PCM0_TX,
> + .rqtype = MEMTODEV,
> + }, {
> + .peri_id = (u8)DMACH_PCM1_RX,
> + .rqtype = DEVTOMEM,
> + }, {
> + .peri_id = (u8)DMACH_PCM1_TX,
> + .rqtype = MEMTODEV,
> + }, {
> + .peri_id = (u8)DMACH_MSM_REQ1,
> + }, {
> + .peri_id = (u8)DMACH_MSM_REQ3,
> + }, {
> + .peri_id = (u8)DMACH_SPI1_RX,
> + .rqtype = DEVTOMEM,
> + .burst_sz = 1,
> + }, {
> + .peri_id = (u8)DMACH_SPI1_TX,
> + .rqtype = MEMTODEV,
> + .burst_sz = 1,
> + }, {
> + .peri_id = (u8)DMACH_I2S0S_TX,
> + .rqtype = MEMTODEV,
> + }, {
> + .peri_id = (u8)DMACH_I2S0_RX,
> + .rqtype = DEVTOMEM,
> + }, {
> + .peri_id = (u8)DMACH_I2S0_TX,
> + .rqtype = MEMTODEV,
> + }, {
> + .peri_id = (u8)DMACH_I2S1_RX,
> + .rqtype = DEVTOMEM,
> + }, {
> + .peri_id = (u8)DMACH_I2S1_TX,
> + .rqtype = MEMTODEV,
> + }, {
> + .peri_id = (u8)DMACH_UART0_RX,
> + .rqtype = DEVTOMEM,
> + .burst_sz = 4,
> + }, {
> + .peri_id = (u8)DMACH_UART0_TX,
> + .rqtype = MEMTODEV,
> + .burst_sz = 4,
> + }, {
> + .peri_id = (u8)DMACH_UART1_RX,
> + .rqtype = DEVTOMEM,
> + .burst_sz = 4,
> + }, {
> + .peri_id = (u8)DMACH_UART1_TX,
> + .rqtype = MEMTODEV,
> + .burst_sz = 4,
> + }, {
> + .peri_id = (u8)DMACH_UART3_RX,
> + .rqtype = DEVTOMEM,
> + .burst_sz = 4,
> + }, {
> + .peri_id = (u8)DMACH_UART3_TX,
> + .rqtype = MEMTODEV,
> + .burst_sz = 4,
> + }, {
> + .peri_id = (u8)DMACH_SLIMBUS1_RX,
> + .rqtype = DEVTOMEM,
> + }, {
> + .peri_id = (u8)DMACH_SLIMBUS1_TX,
> + .rqtype = MEMTODEV,
> + }, {
> + .peri_id = (u8)DMACH_SLIMBUS3_RX,
> + .rqtype = DEVTOMEM,
> + }, {
> + .peri_id = (u8)DMACH_SLIMBUS3_TX,
> + .rqtype = MEMTODEV,
> + }, {
> + .peri_id = (u8)DMACH_SLIMBUS5_RX,
> + .rqtype = DEVTOMEM,
> + }, {
> + .peri_id = (u8)DMACH_SLIMBUS5_TX,
> + .rqtype = MEMTODEV,
> },
> };
>
> -static struct s3c_pl330_platdata exynos4_pdma1_pdata = {
> - .peri = {
> - [0] = DMACH_PCM0_RX,
> - [1] = DMACH_PCM0_TX,
> - [2] = DMACH_PCM1_RX,
> - [3] = DMACH_PCM1_TX,
> - [4] = DMACH_MSM_REQ1,
> - [5] = DMACH_MSM_REQ3,
> - [6] = DMACH_SPI1_RX,
> - [7] = DMACH_SPI1_TX,
> - [8] = DMACH_I2S0S_TX,
> - [9] = DMACH_I2S0_RX,
> - [10] = DMACH_I2S0_TX,
> - [11] = DMACH_I2S1_RX,
> - [12] = DMACH_I2S1_TX,
> - [13] = DMACH_UART0_RX,
> - [14] = DMACH_UART0_TX,
> - [15] = DMACH_UART1_RX,
> - [16] = DMACH_UART1_TX,
> - [17] = DMACH_UART3_RX,
> - [18] = DMACH_UART3_TX,
> - [19] = DMACH_SLIMBUS1_RX,
> - [20] = DMACH_SLIMBUS1_TX,
> - [21] = DMACH_SLIMBUS3_RX,
> - [22] = DMACH_SLIMBUS3_TX,
> - [23] = DMACH_SLIMBUS5_RX,
> - [24] = DMACH_SLIMBUS5_TX,
> - [25] = DMACH_SLIMBUS0AUX_RX,
> - [26] = DMACH_SLIMBUS0AUX_TX,
> - [27] = DMACH_SPDIF,
> - [28] = DMACH_MAX,
> - [29] = DMACH_MAX,
> - [30] = DMACH_MAX,
> - [31] = DMACH_MAX,
> - },
> +struct dma_pl330_platdata exynos4_pdma1_pdata = {
> + .nr_valid_peri = 32,
> + .peri = pdma1_peri,
> };
>
> -static struct platform_device exynos4_device_pdma1 = {
> - .name = "s3c-pl330",
> - .id = 1,
> - .num_resources = ARRAY_SIZE(exynos4_pdma1_resource),
> - .resource = exynos4_pdma1_resource,
> - .dev = {
> +struct amba_device exynos4_device_pdma1 = {
"exynos4_device_pdma1" is not being used anywhere in this patch, i
think pdma1 is for the second instance of DMA.
> + .dev = {
> + .init_name = "dma-pl330",
> .dma_mask = &dma_dmamask,
> .coherent_dma_mask = DMA_BIT_MASK(32),
> .platform_data = &exynos4_pdma1_pdata,
> },
> -};
> -
> -static struct platform_device *exynos4_dmacs[] __initdata = {
> - &exynos4_device_pdma0,
> - &exynos4_device_pdma1,
> + .res = {
> + .start = EXYNOS4_PA_PDMA1,
> + .end = EXYNOS4_PA_PDMA1 + SZ_4K,
> + .flags = IORESOURCE_MEM,
> + },
> + .irq = {IRQ_PDMA1, NO_IRQ},
> + .periphid = 0x00041330,
> };
>
> static int __init exynos4_dma_init(void)
> {
> - platform_add_devices(exynos4_dmacs, ARRAY_SIZE(exynos4_dmacs));
> + amba_device_register(&exynos4_device_pdma0, &iomem_resource);
For some reason you are not registering exynos4_device_pdma1, though
you have provided the platdata.
>
> return 0;
> }
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
More information about the linux-arm-kernel
mailing list