[PATCH 4/7] ARM: GIC: move gic_chip_data structure declaration to header

Kukjin Kim kgene.kim at samsung.com
Mon Jul 4 05:38:08 EDT 2011


Changhwan Youn wrote:
> 
> Since Samsung EXYNOS4210 cannot support register banking in GIC,
> so needs to update CPU interface base address.
> The 'gic_chip_data' is used for it, this patch moves gic_chip_data
> structure declaraton to arch/arm/include/asm/hardware/gic.h to use
> it.
> 
> Cc: Russell King <rmk+kernel at arm.linux.org.uk>

Russell, how do you think this?

As I know, this is needed on Samsung SoC, EXYNOS4210.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

> Signed-off-by: Changhwan Youn <chaos.youn at samsung.com>
> ---
>  arch/arm/common/gic.c               |    6 ------
>  arch/arm/include/asm/hardware/gic.h |    6 ++++++
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c
> index 4ddd0a6..23564ed 100644
> --- a/arch/arm/common/gic.c
> +++ b/arch/arm/common/gic.c
> @@ -38,12 +38,6 @@ static DEFINE_SPINLOCK(irq_controller_lock);
>  /* Address of GIC 0 CPU interface */
>  void __iomem *gic_cpu_base_addr __read_mostly;
> 
> -struct gic_chip_data {
> -	unsigned int irq_offset;
> -	void __iomem *dist_base;
> -	void __iomem *cpu_base;
> -};
> -
>  /*
>   * Supported arch specific GIC irq extension.
>   * Default make them NULL.
> diff --git a/arch/arm/include/asm/hardware/gic.h
> b/arch/arm/include/asm/hardware/gic.h
> index 0691f9d..435d3f8 100644
> --- a/arch/arm/include/asm/hardware/gic.h
> +++ b/arch/arm/include/asm/hardware/gic.h
> @@ -41,6 +41,12 @@ void gic_secondary_init(unsigned int);
>  void gic_cascade_irq(unsigned int gic_nr, unsigned int irq);
>  void gic_raise_softirq(const struct cpumask *mask, unsigned int irq);
>  void gic_enable_ppi(unsigned int);
> +
> +struct gic_chip_data {
> +	unsigned int irq_offset;
> +	void __iomem *dist_base;
> +	void __iomem *cpu_base;
> +};
>  #endif
> 
>  #endif
> --
> 1.7.1




More information about the linux-arm-kernel mailing list