[PATCH 8/8] at91: add arch specific ioremap support
Jean-Christophe PLAGNIOL-VILLARD
plagnioj at jcrosoft.com
Fri Jul 1 13:29:12 EDT 2011
On 17:59 Fri 01 Jul , Arnd Bergmann wrote:
> On Friday 01 July 2011, Jean-Christophe PLAGNIOL-VILLARD wrote:
>
> > +
> > +static inline unsigned int at91_readl(unsigned int pa)
> > +{
> > + return __raw_readl((void __iomem *)AT91_IO_P2V(pa));
> > +}
> > +
>
> This function looks quite unusual and not in a good way. You also don't
> seem to use it at all.
>
> Why is this needed, can can't you change all users to do ioremap?
I don't remember why I put it
the whole idea is that everyone use ioremap now
Best Regards,
J.
More information about the linux-arm-kernel
mailing list