[PATCH 4/7] ARM: EXYNOS4: Support early wakeup while entering sleep mode

Russell King - ARM Linux linux at arm.linux.org.uk
Fri Jul 1 03:44:14 EDT 2011


On Fri, Jul 01, 2011 at 10:03:48AM +0900, Kukjin Kim wrote:
> Russell thanks.
> 
> How do you think to add following for handling failure of cpu_suspend?
> 
> +	mov	r0, #-1

No.  -1 is not an error code, and I refuse to create functions which
use an explicit -1 as a return code to indicate failure.

The code is designed so that the called finisher function can return
a valid errno value.



More information about the linux-arm-kernel mailing list