[PATCH v6 1/1] PRUSS UIO driver support
Hans J. Koch
hjk at hansjkoch.de
Mon Feb 28 16:26:38 EST 2011
On Tue, Mar 01, 2011 at 02:31:35AM +0530, Pratheesh Gangadhar wrote:
> +
> + /* Register PRUSS IRQ lines */
> + p->irq = IRQ_DA8XX_EVTOUT0 + cnt;
> + p->handler = pruss_handler;
> +
> + ret = uio_register_device(&dev->dev, p);
> +
> + if (ret < 0)
> + goto out_free;
> + }
> +
> + spin_lock_init(&lock);
That's too late. uio_register_device() enables the irq, and your spin_lock
is not ready at that time.
> + platform_set_drvdata(dev, info);
> + return 0;
> +
> +out_free:
> + pruss_cleanup(dev, info);
> + return ret;
> +}
Thanks,
Hans
More information about the linux-arm-kernel
mailing list