[PATCH v10 05/18] OMAP2, 3 DSS2 Change driver name to omap_display

Cousson, Benoit b-cousson at ti.com
Mon Feb 28 08:38:32 EST 2011


On 2/28/2011 1:13 PM, Russell King - ARM Linux wrote:
> On Mon, Feb 28, 2011 at 02:10:26PM +0200, Tomi Valkeinen wrote:
>> On Mon, 2011-02-28 at 05:36 -0600, Cousson, Benoit wrote:
>>> Cannot you use a device hierarchy then to do that?
>>>    omap_dss/core
>>>    omap_dss/dsi
>>>    omap_dss/venc
>>>
>>> This is moreover the way the HW is done.
>>
>> Hmm, how would that work? The devices are platform devices, and they
>> have a unique global name, which is used to match the driver for the
>> device.
>
> And not forgetting that '/' is not permitted in device or driver names.

I was not really considering naming the device with a '/'. The idea is 
that the devices will not longer be flat platform devices but something 
like dss devices that will have have a omap_dss parent.

I do not know if that makes sense to store some kind of hierarchy in the 
device model, but encoding the hierarchy in the name like it is proposed 
looks like a hack to me. The point is that the dsi instances might 
potentially be in another part of the SoC. Having the device name based 
on the hierarchy will not allow the driver to bind the device properly.

Please note, that I'm not really sure it is doable with the current 
device model, hence the original question.

Benoit



More information about the linux-arm-kernel mailing list