[PATCH v4 2/2] Defines DA850/AM18xx/OMAPL1-38 SOC resources used by PRUSS UIO driver

[TK, Pratheesh Gangadhar]

Hi,

> -----Original Message-----
> From: Sergei Shtylyov [mailto:sshtylyov at mvista.com]
> Sent: Friday, February 25, 2011 5:18 PM
> To: TK, Pratheesh Gangadhar
> Cc: davinci-linux-open-source at linux.davincidsp.com; hjk at hansjkoch.de;
> gregkh at suse.de; tglx at linutronix.de; arnd at arndb.de; Chatterjee, Amit;
> linux-kernel at vger.kernel.org; linux-arm-kernel at lists.infradead.org
> Subject: Re: [PATCH v4 2/2] Defines DA850/AM18xx/OMAPL1-38 SOC resources
> used by PRUSS UIO driver
> 
> On 24-02-2011 17:06, Pratheesh Gangadhar wrote:
> 
> > This patch defines PRUSS, ECAP clocks, memory and IRQ resources
> > used by PRUSS UIO driver in DA850/AM18xx/OMAPL1-38 devices. UIO
> 
>     It's OMAP-L138.
Ok.
> 
> > driver exports 64K I/O region of PRUSS, 128KB L3 RAM and 256KB
> > DDR buffer to user space. PRUSS has 8 host event interrupt lines
> > mapped to IRQ_DA8XX_EVTOUT0..7 of ARM9 INTC.These in conjunction
> > with shared memory can be used to implement IPC between ARM9 and
> > PRUSS.
> 
> > Signed-off-by: Pratheesh Gangadhar<pratheesh at ti.com>
> [...]
> 
> > diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-
> davinci/board-da850-evm.c
> > index 11f986b..bd85aa3 100644
> > --- a/arch/arm/mach-davinci/board-da850-evm.c
> > +++ b/arch/arm/mach-davinci/board-da850-evm.c
> > @@ -1077,6 +1077,10 @@ static __init void da850_evm_init(void)
> >   		pr_warning("da850_evm_init: i2c0 registration failed: %d\n",
> >   				ret);
> >
> > +	ret = da8xx_register_pruss();
> > +	if (ret)
> > +		pr_warning("da850_evm_init: pruss registration failed: %d\n",
> > +				ret);
> 
>     Use __func__ to print the function name.
> 
> >
> >   	ret = da8xx_register_watchdog();
> >   	if (ret)
> 
>     As I said, please put this into serpate patch.
> 
Ok, will do.
> > diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-
> davinci/da850.c
> > index 3443d97..0096d4f 100644
> > --- a/arch/arm/mach-davinci/da850.c
> > +++ b/arch/arm/mach-davinci/da850.c
> > @@ -238,6 +238,13 @@ static struct clk tptc2_clk = {
> >   	.flags		= ALWAYS_ENABLED,
> >   };
> >
> > +static struct clk pruss_clk = {
> > +	.name		= "pruss",
> > +	.parent		= &pll0_sysclk2,
> > +	.lpsc		= DA8XX_LPSC0_DMAX,
> > +	.flags		= ALWAYS_ENABLED,
> > +};
> > +
> 
>     This conflicts with previously posted patch.
> 
Ok, shall I rename to align with previous patch from Mistral or drop this from my patchset ?
> >   static struct clk uart0_clk = {
> >   	.name		= "uart0",
> >   	.parent		=&pll0_sysclk2,
> > @@ -359,6 +366,30 @@ static struct clk usb20_clk = {
> >   	.gpsc		= 1,
> >   };
> >
> > +static struct clk ecap0_clk = {
> > +	.name		= "ecap0",
> > +	.parent		= &pll0_sysclk2,
> > +	.lpsc		= DA8XX_LPSC1_ECAP,
> > +	.flags		= DA850_CLK_ASYNC3,
> > +	.gpsc		= 1,
> > +};
> > +
> > +static struct clk ecap1_clk = {
> > +	.name		= "ecap1",
> > +	.parent		= &pll0_sysclk2,
> > +	.lpsc		= DA8XX_LPSC1_ECAP,
> > +	.flags		= DA850_CLK_ASYNC3,
> > +	.gpsc		= 1,
> > +};
> > +
> > +static struct clk ecap2_clk = {
> > +	.name		= "ecap2",
> > +	.parent		= &pll0_sysclk2,
> > +	.lpsc		= DA8XX_LPSC1_ECAP,
> > +	.flags		= DA850_CLK_ASYNC3,
> > +	.gpsc		= 1,
> > +};
> > +
> 
>     This is worth separate patch too...
> 
Ok.
> > diff --git a/arch/arm/mach-davinci/devices-da8xx.c b/arch/arm/mach-
> davinci/devices-da8xx.c
> > index beda8a4..4ea3d1f 100644
> > --- a/arch/arm/mach-davinci/devices-da8xx.c
> > +++ b/arch/arm/mach-davinci/devices-da8xx.c
> > @@ -725,3 +725,76 @@ int __init da8xx_register_cpuidle(void)
> >
> >   	return platform_device_register(&da8xx_cpuidle_device);
> >   }
> > +static struct resource pruss_resources[] = {
> > +	[0] = {
> > +		.start  = DA8XX_PRUSS_BASE,
> > +		.end    = DA8XX_PRUSS_BASE + SZ_64K - 1,
> > +		.flags  = IORESOURCE_MEM,
> > +	},
> > +	[1] = {
> > +		.start  = DA8XX_L3RAM_BASE,
> > +		.end    = DA8XX_L3RAM_BASE + SZ_128K - 1,
> > +		.flags  = IORESOURCE_MEM,
> > +	},
> > +	[2] = {
> > +		.start  = 0,
> > +		.end    = SZ_256K - 1,
> 
>     Huh? I don't see where it's filled...
> 
The current use is only to indicate memory block size to the PRUSS UIO driver when we allocate DDR memory using dma_alloc_coherent. sram_alloc is changed to use L3_RAM (128KB) instead of ARM RAM (8KB) in Mistral patch set - I need to follow the same convention for L3 RAM as well if I need to align with that patch. Is there a better way to do this?
> > +		.flags  = IORESOURCE_MEM,
> > +	},
> > +
> [...]
> > +int __init da8xx_register_pruss()
> > +{
> > +	return platform_device_register(&pruss_device);
> > +}
> > diff --git a/arch/arm/mach-davinci/include/mach/da8xx.h b/arch/arm/mach-
> davinci/include/mach/da8xx.h
> > index cfcb223..3ed6ee0 100644
> > --- a/arch/arm/mach-davinci/include/mach/da8xx.h
> > +++ b/arch/arm/mach-davinci/include/mach/da8xx.h
> > @@ -60,6 +60,7 @@ extern unsigned int da850_max_speed;
> >   #define DA8XX_PLL0_BASE		0x01c11000
> >   #define DA8XX_TIMER64P0_BASE	0x01c20000
> >   #define DA8XX_TIMER64P1_BASE	0x01c21000
> > +#define DA8XX_PRUSS_BASE	0x01c30000
> >   #define DA8XX_GPIO_BASE		0x01e26000
> >   #define DA8XX_PSC1_BASE		0x01e27000
> >   #define DA8XX_LCD_CNTRL_BASE	0x01e13000
> > @@ -68,6 +69,7 @@ extern unsigned int da850_max_speed;
> >   #define DA8XX_AEMIF_CS2_BASE	0x60000000
> >   #define DA8XX_AEMIF_CS3_BASE	0x62000000
> >   #define DA8XX_AEMIF_CTL_BASE	0x68000000
> > +#define DA8XX_L3RAM_BASE	0x80000000
> 
>     There were already patches defining macros for these base addresses...
>
Ok - will align with this.

Thanks,
Pratheesh