[PATCH V4 0/6] pxa3xx_nand update series set version 4

Lei Wen adrian.wenl at gmail.com
Sun Feb 27 21:25:34 EST 2011


On Fri, Feb 25, 2011 at 6:39 PM, Artem Bityutskiy <dedekind1 at gmail.com> wrote:
> On Fri, 2011-02-18 at 16:57 +0800, Lei Wen wrote:
>> Change from previous version:
>> rework the patch set accroding to Eric's suggestion.
>> Move the recode judgement to the after command execution.
>>
>> Lei Wen (6):
>>   pxa3xx_nand: make scan procedure more clear
>>   pxa3xx_nand: rework irq logic
>>   pxa3xx_nand: discard wait_for_event,write_cmd,__readid function
>>   pxa3xx_nand: unify prepare command
>>   pxa3xx_nand: mtd scan id process could be defined by driver itself
>>   pxa3xx_nand: clean the keep configure code
>
> Hi, could you please make checkpatch.pl happy and re-send the patches?
>
> There are many issues. OK, some are fine, do not try to fix them, e.g.:
>
> WARNING: line over 80 characters
> #127: FILE: drivers/mtd/nand/pxa3xx_nand.c:221:
> +{ "512MiB 16-bit", 0xcc2c,  64, 2048, 16, 16, 4096, &default_cmdset, &timing[2] },
>
> but some are clearly stylistic errors:
>
> ERROR: else should follow close brace '}'
> #249: FILE: drivers/mtd/nand/pxa3xx_nand.c:539:
> +                }
> +                else {
>
> etc.
>

Thanks for point that out...
I would post update patch which include the fix for that.

Best regards,
Lei



More information about the linux-arm-kernel mailing list