[PATCH] nmk-gpio: use request_irq instead of chained handler

Will Deacon will.deacon at arm.com
Fri Feb 25 12:16:25 EST 2011


Hi Linus,

> 2011/2/23 Will Deacon <will.deacon at arm.com>:
> >> On Wed, Feb 23, 2011 at 22:47, Will Deacon <will.deacon at arm.com> wrote:
> >> >> __nmk_gpio_irq_handler doesn't do anything more that what a normal handler
> >> >> does, so it can become one.  This is also needed for changing the GIC
> >> >> implementation to a different flow handler.
> >> >>
> >> >> Signed-off-by: Rabin Vincent <rabin.vincent at stericsson.com>
> >> >
> >> > mach-nomadik only seems to use the vic. Why does this GPIO handler
> >> > need updating?
> >>
> >> plat-nomadik/gpio.c is also used by mach-ux500, which uses the GIC.
> >
> > Ah yes, sorry I missed that one. I'm happy to include any patches from you
> > in the GIC fasteoi series if it makes merging easier.
> 
> OK if this one is OK I sure prefer that you take it in your series Will,
> since you have the whole picture of what you want to do with the
> GIC.
> 
> It'll likely collide with the stuff I have stacked up for the 2.6.39 merge
> window though, which will be pull-requested any day now.

Sure. I'll add a patch to my series that makes the minimal change required
and post it next week.

Will






More information about the linux-arm-kernel mailing list