[TRIVIAL/PATCH] ARM: hw_breakpoint: Fix newlines in WARN messages
Lothar Waßmann
LW at KARO-electronics.de
Fri Feb 25 01:38:23 EST 2011
Hi,
Stephen Boyd writes:
> These warnings are missing newlines and spaces causing confusing
> looking output when they trigger.
>
> Cc: Will Deacon <will.deacon at arm.com>
> Signed-off-by: Stephen Boyd <sboyd at codeaurora.org>
> ---
> arch/arm/kernel/hw_breakpoint.c | 13 +++++++------
> 1 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/kernel/hw_breakpoint.c b/arch/arm/kernel/hw_breakpoint.c
> index d600bd3..5aab00e 100644
> --- a/arch/arm/kernel/hw_breakpoint.c
> +++ b/arch/arm/kernel/hw_breakpoint.c
> @@ -238,8 +238,8 @@ static int enable_monitor_mode(void)
> ARM_DBG_READ(c1, 0, dscr);
>
> /* Ensure that halting mode is disabled. */
> - if (WARN_ONCE(dscr & ARM_DSCR_HDBGEN, "halting debug mode enabled."
> - "Unable to access hardware resources.")) {
> + if (WARN_ONCE(dscr & ARM_DSCR_HDBGEN, "halting debug mode enabled. "
> + "Unable to access hardware resources.\n")) {
>
I'd prefer the message text not to be line wrapped, even if it
violates the general line length rule, because that makes it easier to
grep for the message in the source code.
Lothar Waßmann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
More information about the linux-arm-kernel
mailing list