[PATCH 4/5] ARM: Tegra: Create defines for GPIO names

Stephen Warren swarren at nvidia.com
Wed Feb 23 15:49:46 EST 2011


Colin Cross wrote at Wednesday, February 23, 2011 1:39 PM:
> 
> On Wed, Feb 23, 2011 at 12:35 PM, Stephen Warren <swarren at nvidia.com> wrote:
> > Colin Cross wrote at Wednesday, February 23, 2011 12:09 PM:
> >> On Wed, Feb 23, 2011 at 10:58 AM, Stephen Warren <swarren at nvidia.com> wrote:
> >> > This ensures they're kept in sync between platform_data definitions and
> >> > the GPIO table initialization.
> >>
> >> Can you name these for what they are used for (if they have a single use)?
> >> i.e. TEGRA_GPIO_EMMC_CD instead of TEGRA_GPIO_SD2_CD
> >
> > Are you looking for correlation with the schematics, or something else;
>...
> 
> I meant use the name of the device they are connected to (if there is
> one).  By EMMC I meant the embedded MMC storage device.  The gpio is
> not notable because it is used by the SDIO driver for port 2, it is
> notable because it is connected to the EMMC chip or the wifi chip or a
> card slot.

The GPIOs currently in the code are for SD slots/connectors; we don't have
any GPIO definitions for any internal MMC memory, or WiFi chips.

I guess the numbering could be changed; 2 vs. 4 don't very obviously map to
the slots on the board for the user, yet the only thing better I can think
of would be the connector numbers on the silkscreen?

-- 
nvpublic




More information about the linux-arm-kernel mailing list