[PATCH] DaVinci: fix compilation warnings in <mach/clkdev.h>

Nori, Sekhar nsekhar at ti.com
Wed Feb 23 07:01:38 EST 2011


Hi Sergei,

On Thu, Feb 10, 2011 at 00:03:23, Sergei Shtylyov wrote:
> Commit 6d803ba736abb5e122dede70a4720e4843dd6df4 (ARM: 6483/1: arm & sh:
> factorised duplicated clkdev.c) caused the following warnings:
> 
> In file included from /home/headless/src/kernel.org/linux-davinci/arch/arm/
> include/asm/clkdev.h:17,
>                  from include/linux/clkdev.h:15,
>                  from arch/arm/mach-davinci/clock.h:71,
>                  from arch/arm/mach-davinci/common.c:22:
> arch/arm/mach-davinci/include/mach/clkdev.h:4: warning: `struct clk' declared
> inside parameter list
> arch/arm/mach-davinci/include/mach/clkdev.h:4: warning: its scope is only this
> definition or declaration, which is probably not what you want
> arch/arm/mach-davinci/include/mach/clkdev.h:9: warning: `struct clk' declared
> inside parameter list
> 
> Signed-off-by: Sergei Shtylyov <sshtylyov at ru.mvista.com>

>  
> +struct clk;
> +
>  static inline int __clk_get(struct clk *clk)
>  {
>  	return 1;

This looks good to me. It should be queued for 2.6.38-rc
Kevin is going to handle the 2.6.38 and 2.6.39 kernels
so will queue this for him.

Thanks,
Sekhar




More information about the linux-arm-kernel mailing list