[PATCH 3/5] ARM: tegra: update GPIO chained IRQ handler to use EOI in parent chip

Will Deacon will.deacon at arm.com
Tue Feb 22 14:21:09 EST 2011


Hi Colin,

> On Mon, Feb 21, 2011 at 7:28 AM, Will Deacon <will.deacon at arm.com> wrote:
> > The chained GPIO IRQ handler on Tegra calls ->irq_ack on the parent
> > chip prior to handling the interrupt.
> >
> > This patch updates the code to use ->irq_eoi now that the GIC has moved
> > to using the fasteoi flow model.
> >
> > Cc: Colin Cross <ccross at google.com>
> > Signed-off-by: Will Deacon <will.deacon at arm.com>
> > ---
> >  arch/arm/mach-tegra/gpio.c |   17 +----------------
> >  1 files changed, 1 insertions(+), 16 deletions(-)

[...]

> Acked-by: Colin Cross <ccross at android.com>

Thanks Colin.

> Works with chained gpio handlers on Tegra, although the patch is
> filled with = escaping.

Hmm, I've seen this problem before. See Russell's explanation here:

http://lists.arm.linux.org.uk/lurker/message/20101201.172105.938cf2c5.en.html

I don't believe it's a problem my end, but if it starts happening
regularly I'll investigate further.

Cheers,

Will







More information about the linux-arm-kernel mailing list