[PATCH v2 5/6] davinci: add spi devices support for da850/omap-l138/am18x evm

[Nori, Sekhar]

On Wed, Feb 09, 2011 at 18:41:53, Michael Williamson wrote:
> From: Sekhar Nori <nsekhar at ti.com>
> 
> This patch adds the on-board SPI flash device to the
> DA850/OMAP-L138/AM18x EVM. It also registers the SPI flash
> device to the MTD subsystem.
> 
> Based on SPI flash device support for MityDSP-L138F platform.
> 
> Signed-off-by: Sekhar Nori <nsekhar at ti.com>
> [michael.williamson at criticallink.com: moved da850_evm_spi1_pdata to devices-da8xx.c]
> Signed-off-by: Michael Williamson <michael.williamson at criticallink.com>
> +static void __init da850evm_init_spi1(struct spi_board_info *info, unsigned len)
> +{
> +	int ret;
> +
> +	ret = spi_register_board_info(info, len);
> +	if (ret)
> +		pr_warning("failed to register board info : %d\n", ret);
> +
> +	da8xx_spi_pdata[1].num_chipselect = len;
> +
> +	ret = da8xx_register_spi(1);
> +	if (ret)
> +		pr_warning("failed to register spi 1 device : %d\n", ret);
> +}

When reposting can you also modify this to print function name
with the error message (so it is easy to find what exactly failed).

The same thing needs to be done with DA830 EVM.

Rest of the stuff looks good to me.

Thanks,
Sekhar