[linux-pm] [PATCH] amba: move to pm ops

Rabin Vincent rabin at rab.in
Mon Feb 21 02:36:59 EST 2011


On Thu, Feb 17, 2011 at 23:14, Takashi Iwai <tiwai at suse.de> wrote:
> At Thu, 17 Feb 2011 13:19:46 +0530,
> Rabin Vincent wrote:
>>
>> Support pm_ops in the AMBA bus instead of the legacy ops.   pm_ops is needed
>> for runtime pm, and there is also a general move to convert drivers to
>> dev_pm_ops rather than bus specific PM ops in order to facilitate core
>> development.
>>
>> Since there are only 6 AMBA drivers using suspend/resume, convert them all in
>> one go and directly use the GENERIC_SUBSYS_PM_OPS in the bus.
>>
>> Cc: Dmitry Torokhov <dmitry.torokhov at gmail.com>
>> Cc: Chris Ball <cjb at laptop.org>
>> Cc: Grant Likely <grant.likely at secretlab.ca>
>> Cc: Takashi Iwai <tiwai at suse.de>
>> Cc: Linus Walleij <linus.walleij at linaro.org>
>> Cc: Greg Kroah-Hartman <gregkh at suse.de>
>> Signed-off-by: Rabin Vincent <rabin.vincent at stericsson.com>
>
> For sound/arm/aaci.c,
>
>  Acked-by: Takashi Iwai <tiwai at suse.de>
>
> Though, this would result in a zero-filled *_pm struct when
> CONFIG_PM_* isn't set?  It's a few bytes wastes ;)

Thank you for the ack.  However, in v2 of the patch I've done a
different implementation in the bus code that doesn't necessitate
the conversion of all the drivers together, so this part is
dropped.  I will take this comment into consideration if I do
end up converting all the drivers.  Thanks.



More information about the linux-arm-kernel mailing list