[PATCH] arm: imx: Zero entire imxdma structure

Russell King - ARM Linux linux at arm.linux.org.uk
Sun Feb 20 18:04:58 EST 2011


On Sun, Feb 20, 2011 at 10:59:24PM +0000, Ilia Mirkin wrote:
> On Sun, Feb 20, 2011 at 10:10 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> > The semantic match that finds the problem:
> > // <smpl>
> > @@
> > type T;
> > identifier x;
> > @@
> >
> > T *x;
> > ...
> > * memset(x, ..., ... * sizeof(x) * ...);
> > // </smpl>
> >
> > Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> >
> > ---
> >  arch/arm/mach-imx/dma-v1.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > Untested, lack of tool chain and hardware. But there's definitely something
> > odd going on here, and this seemed like the most logical fix.
> 
> Doing some quick digging (as I've been discovering that a few of the
> other patches I was planning on sending have already been sent out in
> the past), I noticed that this same patch was already sent on Dec 9,
> 2009 by Julia Lawall[1] (back when it was plat-mxc/dma-mx1-mx2.c), and
> then again by Vasiliy Kulikov[2] on Oct 10, 2010.
> 
> On each occasion, the response was positive, but patch has yet to make
> it upstream. Weird.

Sascha, are you going to take this patch?



More information about the linux-arm-kernel mailing list